Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloud_firestore_odm): Add support for DateTime/Timestamp #8563

Merged
merged 10 commits into from Jul 11, 2022

Conversation

rrousselGit
Copy link
Contributor

@rrousselGit rrousselGit commented May 2, 2022

Description

Blocked by google/json_serializable.dart#1135

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@rrousselGit rrousselGit marked this pull request as draft May 2, 2022 17:50
@github-actions
Copy link

github-actions bot commented May 2, 2022

Visit the preview URL for this PR (updated for commit 19e94e3):

https://flutter-firebase-docs--pr8563-rrousselgit-odm-tim-x8z405jl.web.app

(expires Tue, 10 May 2022 08:58:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@russellwheatley russellwheatley added the blocked: do-not-merge PR blocked externally label May 3, 2022
@wstrange
Copy link

wstrange commented Jul 3, 2022

Now that the json blocker has been merged (I think?) can this PR proceed?

@rrousselGit
Copy link
Contributor Author

The blocker isn't json_serializable.

@rrousselGit rrousselGit marked this pull request as ready for review July 6, 2022 11:00
@rrousselGit rrousselGit removed the blocked: do-not-merge PR blocked externally label Jul 6, 2022
@rrousselGit rrousselGit merged commit f2ea369 into master Jul 11, 2022
@rrousselGit rrousselGit deleted the @rrousselGit/odm-time branch July 11, 2022 12:31
@firebase firebase locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants