update Jax-Metal CI runner with nightly jaxlib config #21070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skye
requested changes
May 4, 2024
| @@ -302,13 +302,11 @@ def testCountNonzero(self, shape, dtype, axis): | |||
| self._CheckAgainstNumpy(np_fun, jnp_fun, args_maker, check_dtypes=False) | |||
| self._CompileAndCheck(jnp_fun, args_maker) | |||
|
|
|||
| @jtu.sample_product(shape=all_shapes, dtype=all_dtypes) | |||
| @jtu.sample_product(shape=nonzerodim_shapes, dtype=all_dtypes) | |||
There was a problem hiding this comment.
OOC why did you need to reduce coverage? Were new failures introduced in jaxlib nightly?
There was a problem hiding this comment.
metal_plugin_ci has been failing on tip since two weeks ago. I suspect there is a change in JAX? So the coverage changes here are synced from lax_numpy_test.
There was a problem hiding this comment.
Ah. More reason to sync up the test files!
skye
approved these changes
May 6, 2024
| @@ -302,13 +302,11 @@ def testCountNonzero(self, shape, dtype, axis): | |||
| self._CheckAgainstNumpy(np_fun, jnp_fun, args_maker, check_dtypes=False) | |||
| self._CompileAndCheck(jnp_fun, args_maker) | |||
|
|
|||
| @jtu.sample_product(shape=all_shapes, dtype=all_dtypes) | |||
| @jtu.sample_product(shape=nonzerodim_shapes, dtype=all_dtypes) | |||
There was a problem hiding this comment.
Ah. More reason to sync up the test files!
google-ml-butler
bot
added
kokoro:force-run
pull ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nightly jaxlib config to Jax-Metal CI runner.
Sync lax_metal_test with lax_numpy_test