Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NullableAnnot.java #6525

Closed
wants to merge 1 commit into from
Closed

Conversation

Shahil093
Copy link

@google-cla
Copy link

google-cla bot commented Jun 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jbduncan
Copy link
Contributor

jbduncan commented Jun 1, 2023

@Shahil093 Welcome to Guava, again!

I don't know if you've seen the contribution guidelines yet, but on a cursory look, it looks like this PR doesn't really add anything to Guava and is very unlikely to be accepted, for two reasons:

  1. The story you linked to is about annotating existing code with results from the mentioned paper, whereas your code just adds new, example code, so unless you're the author of the paper, this story probably wouldn't be a good one to pick up.
  2. Guava very rarely accepts external contributions nowadays for reasons noted in the contribution guidelines, with small bug fixes and documentation fixes being two notable exceptions.

If you're looking you get into open source, then you may find this this advice and this advice I wrote many years ago helpful.

I hope this helps!

@chaoren
Copy link
Member

chaoren commented Jun 1, 2023

Thanks for looking into this and responding, @jbduncan. Indeed, this PR seems to be coming from a misunderstanding of #6510.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants