New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor use System.arraycopy() to copy array. #6445
base: master
Are you sure you want to change the base?
Conversation
I have a question about why should we use |
That's unlikely; got a citation for that benchmark? |
Not sure the change was a bad idea. (Not sure it's worth changing either, but...) |
For case 1: CharEscaper charEscaper =
createSimpleCharEscaper(
ImmutableMap.<Character, char[]>builder()
.put('x', "length less than 50".toCharArray())
.put('y', "length is too long, .................................................".toCharArray())
.put('z', "<lo>".toCharArray())
.buildOrThrow());
UnicodeEscaper unicodeEscaper = Escapers.asUnicodeEscaper(charEscaper);
unicodeEscaper.escape("xxxxxxx") Usually, the case 1 is better way, do you think the case 2 is necessary? |
It's a little pity that I didn't preserve the benchmark test process and result, but when I continue to run it much more times I start to find that the result is not always like what I am thinking, it looks like unstable, sometimes the I'm having some doubts, maybe my personal computer or environment has impact on the test result, or my test cases are not completely exact, not sure about that. But anyway, at least I think |
|
No description provided.