Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change private access modifiers for constants in MediaType #6042

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scazacioc
Copy link

Change access modifier to public for

private static final String APPLICATION_TYPE = "application";
private static final String AUDIO_TYPE = "audio";
private static final String IMAGE_TYPE = "image";
private static final String TEXT_TYPE = "text";
private static final String VIDEO_TYPE = "video";

private static final String WILDCARD = "*";

@cgdecker cgdecker added the P3 label May 9, 2022
@cgdecker
Copy link
Member

cgdecker commented May 9, 2022

Is there a particular reason you want these made public? I'm not necessarily opposed, but it would mean having a mix of public MediaType and String constants in the class, which could be awkward. We'd also need Javadoc on the public fields, etc.

@scazacioc
Copy link
Author

The change is related to these issues :
#5794

@google google deleted a comment from isae Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants