Be clearer about what types we're catching. #6033
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be clearer about what types we're catching.
In particular, this helps make clearer that none of these particular
catch
blocks catch arbitrary checked exceptions—and thus that none of them catchInterruptedException
.Also, I've removed some
catch (Throwable t)
blocks fromFakeTimeLimiter
. They could never be hit, since previous blocks had caught bothError
andException
(in the case ofCallable
) orRuntimeException
(in the case ofRunnable
).RELNOTES=n/a