Set -source 8 -target 8 in the open-source build, and remove Java8Usage.
#5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…sage. This is largely a rollback of the original Java8Usage change, but I've modified it in a few ways: - I set `-source 8 -target 8` in the backport. - I kept the code to make includes/excludes fully work with maven-compiler-plugin, since that could save us some confusion down the line. - I incorporated a rollback of the changes to Preconditions from CL 361700569, in which I moved the warning from MoreObjects to Preconditions. - I added errors to our internal release scripts so that we don't accidentally make a release that drops Java 7 support before we're ready. Fixes #5269 PiperOrigin-RevId: 364405695
copybara-service
bot
force-pushed
the
test_364405695
branch
from
d7058a4
to
9cffbe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
-source 8 -target 8in the open-source build, and remove Java8Usage.This is largely a rollback of the original Java8Usage change, but I've modified it in a few ways:
-source 8 -target 8in the backport.Fixes #5269