Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for RuntimeTypeAdapterFactory. #888

Closed
wants to merge 1 commit into from
Closed

Conversation

leangl
Copy link

@leangl leangl commented Jul 13, 2016

RuntimeTypeAdapterFactory stopped working since the 2.0 release. This should fix it, I can provide the corresponding test cases if needed.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@JakeWharton
Copy link
Contributor

Test cases are required, yes.

@swankjesse
Copy link
Collaborator

This is working as designed. If you have a problem with the design, we can address that.

Basically RuntimeTypeAdapterFactory only triggers when the supertype is declared:

   Shape shape;

It doesn't trigger when a subtype is declared:

   Square square;

There’s not much reason to use RuntimeTypeAdapterFactory in that case.

@todoooo
Copy link

todoooo commented Jul 25, 2016

This pull request makes sense. The adapter factory interrogates the class type of the instance during serialisation, not the declared class type. The original implementation only works for deserialisation.

@leangl
Copy link
Author

leangl commented Jul 26, 2016

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@google-cla google-cla bot added the cla: no label Nov 11, 2021
@Marcono1234
Copy link
Collaborator

Marcono1234 commented Jul 29, 2022

This was resolved by #2160. Thank you nonetheless for your pull request!

@Marcono1234 Marcono1234 closed this Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants