Check if class can be instantiated based on class modifiers. Fix for #817 #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,79 @@ | |||
| /* | |||
| * Copyright (C) 2016 Ugljesa Jovanovic | |||
There was a problem hiding this comment.
Sorry, we won’t accept pull requests unless you assign copyright to either Google or Gson Authors. (We don’t want to have to get your permission later if we need to change the license of the whole project.)
|
Looks good but I’ve got some comments |
|
@swankjesse Should I squash this into one commit? |
| * throw an {@link java.lang.UnsupportedOperationException} | ||
| * @param c instance of the class to be checked | ||
| */ | ||
| private static void assertInstantiable(Class c) { |
There was a problem hiding this comment.
supernit: should be Class<?> because Class is a raw type.
|
LGTM! |
|
Yes, please squash into one commit. |
…hrow an unsupported operation exception.
|
@swankjesse Done! Thanks for the comments! |
|
Thanks! |
sebasjm
pushed a commit
to sebasjm/gson
that referenced
this pull request
Mar 11, 2018
Check if class can be instantiated based on class modifiers. Fix for google#817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If class can't be instantiated throw an unsupported operation exception. On different android devices attempt to instantiate interface or abstract class would crash the VM sometimes with only a segmentation fault message and no other useful logs (Issue #817). Checking for interface or abstract class modifiers before trying to allocate instance and throwing an exception will help debugging.