Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorings #2664

Closed
wants to merge 3 commits into from
Closed

Refactorings #2664

wants to merge 3 commits into from

Conversation

pompeiifreckles
Copy link

Purpose

Description

Checklist

  • New code follows the Google Java Style Guide
    This is automatically checked by mvn verify, but can also be checked on its own using mvn spotless:check.
    Style violations can be fixed using mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Siddharth Bhardwaj and others added 3 commits March 3, 2024 23:18
1. Deserialization of Generics with Type Token
   This test case focuses on the deserialization of a generic data
   structure using TypeToken to accurately maintain type information.
2. Custom Serialization and Deserialization of Enums
   This test ensures that custom serializers and deserializers for
   enums work as expected, preserving the ability to encode additional
   information or apply custom logic.
3. Handling Date Formats during Serialization and Deserialization
   This test verifies the custom date formats during serialization and
   deserialization, ensuring that GSON can correctly parse and format
   dates according to specified patterns.
Copy link

google-cla bot commented Apr 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@eamonnmcmanus
Copy link
Member

Could you give some background on what you are trying to achieve here? We are definitely not going to accept a huge PR like this without explanation, even if it were correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants