Adjust version numbers and a test to conform to the SemVer spec. #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10 without the .0 patch version, and adjusted `GsonVersionDiagnosticsTest` so it would accept that, as well as the two-digit `10`. Here we make the test no longer accept versions without a patch number, while still accepting two-digit minor versions of course. We also change the snapshot version to 2.10.1-SNAPSHOT instead of 2.11.
Marcono1234
approved these changes
Nov 13, 2022
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Jan 20, 2023
…gle#2237) * Adjust version numbers and a test to conform to the SemVer spec. Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10 without the .0 patch version, and adjusted `GsonVersionDiagnosticsTest` so it would accept that, as well as the two-digit `10`. Here we make the test no longer accept versions without a patch number, while still accepting two-digit minor versions of course. We also change the snapshot version to 2.11.0-SNAPSHOT instead of 2.11-SNAPSHOT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gson releases since 2.8.0 have been following this spec. We mistakenly released 2.10 without the .0 patch version, and adjusted
GsonVersionDiagnosticsTestso it would accept that, as well as the two-digit10. Here we make the test no longer accept versions without a patch number, while still accepting two-digit minor versions of course. We also change the snapshot version to 2.11.0-SNAPSHOT instead of 2.11-SNAPSHOT.