Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing getType() in Maps Examples #2208

Closed
wants to merge 1 commit into from

Conversation

jonathan-benn
Copy link

The code as-written does not compile! :(

The code as-written does not compile! :(
@google-cla
Copy link

google-cla bot commented Sep 29, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Marcono1234
Copy link
Collaborator

This was actually a deliberate change done by #1700 because in the next release there will be fromJson overloads with TypeToken parameter which will be the recommended approach because they are more type-safe (see #1700 for details).

Though I understand that this change to the user guide is misleading when those changes have not been released yet or for users of older Gson versions; I have tried to address this in #2209.

@eamonnmcmanus
Copy link
Member

I think this indeed addressed by #2209, though we should probably also make a new release fairly soon that includes the API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants