Specify optional dependency on sun.misc.Unsafe
#1999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
force-pushed
the
marcono1234/sun-misc-dependency
branch
from
00ae6d0
to
91a780a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1695 (though maybe Gson documentation could be improved to mention usage of
Unsafe)(Hopefully) resolves #1981
I have marked this as draft because I am not very familiar with OSGi. To be tested:
UnsafeUnsafeand Gson is able to construct instances of class without default constructor (by usingUnsafe)org.osgi.framework.bootdelegation=sun.misc.*org.osgi.framework.system.packages.extra=sun.miscSee also this StackOverflow answer and diffplug/osgiX README.
Ideally a test as proposed by #1993 should be added as well (with some adjustments), but the class from #1993 cannot be reused because the CLA is not signed.