Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing to serialize Collection or Map with inaccessible constructor #1902

Merged
merged 8 commits into from Nov 9, 2021
Merged

Fix failing to serialize Collection or Map with inaccessible constructor #1902

merged 8 commits into from Nov 9, 2021

Commits on Jun 3, 2021

  1. Remove UnsafeReflectionAccessor 

    Revert google#1218

Usage of sun.misc.Unsafe to change internal AccessibleObject.override field
to suppress JPMS warnings goes against the intentions of the JPMS and does not
work anymore in newer versions, see google#1540.
Therefore remove it and instead create a descriptive exception when making a
member accessible fails. If necessary users can also still use `java` command
line flags to open external modules.
    @Marcono1234
    Marcono1234 committed Jun 3, 2021
    Copy the full SHA
    84afa36 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Fix failing to serialize Collection or Map with inaccessible constructor 

    Also remove tests which rely on Java implementation details.
    @Marcono1234
    Marcono1234 committed Jun 4, 2021
    Copy the full SHA
    9620747 View commit details
    Browse the repository at this point in the history

  2. Don't keep reference to access exception of ConstructorConstructor 

    This also avoids a confusing stack trace, since the previously caught
exception might have had a complete unrelated stack trace.
    @Marcono1234
    Marcono1234 committed Jun 4, 2021
    Copy the full SHA
    3acc2e4 View commit details
    Browse the repository at this point in the history

  3. Remove Maven toolchain requirement

    @Marcono1234
    Marcono1234 committed Jun 4, 2021
    Copy the full SHA
    6819419 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2021

  1. Merge branch 'master' into marcono1234/inaccessible-object-exception

    @Marcono1234
    Marcono1234 committed Nov 6, 2021
    Copy the full SHA
    41ff3e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2021

  1. Merge branch 'master' into marcono1234/inaccessible-object-exception

    @Marcono1234
    Marcono1234 committed Nov 8, 2021
    Copy the full SHA
    0696e12 View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @Marcono1234
    Marcono1234 committed Nov 8, 2021
    Copy the full SHA
    2dfccd2 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2021

  1. Add back test for Security Manager

    @Marcono1234
    Marcono1234 committed Nov 9, 2021
    Copy the full SHA
    9140460 View commit details
    Browse the repository at this point in the history