Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeAdapterRuntimeTypeWrapper not detecting reflective TreeTypeAdapter and FutureTypeAdapter #1787

Merged
merged 8 commits into from Oct 10, 2022
Merged

Fix TypeAdapterRuntimeTypeWrapper not detecting reflective TreeTypeAdapter and FutureTypeAdapter #1787

merged 8 commits into from Oct 10, 2022

Commits on Sep 19, 2020

  1. Fix TypeAdapterRuntimeTypeWrapper not detecting reflective TreeTypeAd… 

    …apter

Previously on serialization TypeAdapterRuntimeTypeWrapper preferred a
TreeTypeAdapter without `serializer` which falls back to the reflective
adapter. This behavior was incorrect because it caused the reflective
adapter for a Base class to be used for serialization (indirectly as
TreeTypeAdapter delegate) instead of using the reflective adapter for
a Subclass extending Base.
    @Marcono1234
    Marcono1234 committed Sep 19, 2020
    Copy the full SHA
    764286a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Merge branch 'master' into marcono1234/TypeAdapterRuntimeTypeWrapper-… 

    …not-detecting-reflective-TreeTypeAdapter
    @Marcono1234
    Marcono1234 committed Aug 20, 2022
    Copy the full SHA
    5be9071 View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @Marcono1234
    Marcono1234 committed Aug 20, 2022
    Copy the full SHA
    767c10e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Merge branch 'master' into marcono1234/TypeAdapterRuntimeTypeWrapper-… 

    …not-detecting-reflective-TreeTypeAdapter
    @Marcono1234
    Marcono1234 committed Oct 8, 2022
    Copy the full SHA
    3d2b33a View commit details
    Browse the repository at this point in the history

  2. Convert TypeAdapterRuntimeTypeWrapperTest to JUnit 4 test

    @Marcono1234
    Marcono1234 committed Oct 8, 2022
    Copy the full SHA
    f980e6d View commit details
    Browse the repository at this point in the history

  3. Prefer wrapped reflective adapter for serialization of subclass

    @Marcono1234
    Marcono1234 committed Oct 8, 2022
    Copy the full SHA
    eb96663 View commit details
    Browse the repository at this point in the history

  4. Detect reflective adapter used as delegate for Gson.FutureTypeAdapter

    @Marcono1234
    Marcono1234 committed Oct 8, 2022
    Copy the full SHA
    dd199e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Tiny style tweak.

    @eamonnmcmanus
    eamonnmcmanus committed Oct 10, 2022
    Copy the full SHA
    aeda2bd View commit details
    Browse the repository at this point in the history