Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of bnd-maven-plugin #1770

Closed
wants to merge 1 commit into from
Closed

Update to latest version of bnd-maven-plugin #1770

wants to merge 1 commit into from

Conversation

mbooth101
Copy link

This version has a couple of advantages:

  1. It is aware of module-info.class files, which means we don't
    need to manually override the "Require-Capability" header.

  2. External packages used by reflection are now detected, i.e.
    the "sun.misc" package is now added to the "Import-Package"
    header. This is manually given optional resolution since it
    is obviously not present on all JVMs.

  3. It also introduces some new useful OSGi headers:

  • Bundle-DocURL (overriden with correct URL for manual)
  • Bundle-License
  • Bundle-SCM

This change also removes unnecessary mention of the felix
bundle-plugin in the pluginManagement section of the parent pom.

Signed-off-by: Mat Booth mat.booth@redhat.com

This version has a couple of advantages:

1) It is aware of module-info.class files, which means we don't
need to manually override the "Require-Capability" header.

2) External packages used by reflection are now detected, i.e.
the "sun.misc" package is now added to the "Import-Package"
header. This is manually given optional resolution since it
is obviously not present on all JVMs.

3) It also introduces some new useful OSGi headers:
 - Bundle-DocURL (overriden with correct URL for manual)
 - Bundle-License
 - Bundle-SCM

This change also removes unnecessary mention of the felix
bundle-plugin in the pluginManagement section of the parent pom.

Signed-off-by: Mat Booth <mat.booth@redhat.com>
@google-cla
Copy link

google-cla bot commented Aug 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 27, 2020
@mbooth101
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 27, 2020
@mbooth101
Copy link
Author

Any thoughts on this?

@Marcono1234
Copy link
Collaborator

Thanks for the PR! Some of this has already been implemented by #1993 and the bnd-maven-plugin has been updated as well. Bundle-DocURL seems to be auto-generated to point to this GitHub repository, so maybe that is fine already.

It is aware of module-info.class files, which means we don't need to manually override the "Require-Capability" header.

Not sure if that would yield the desired results (and work correctly because module-info.class generation is a bit complex at the moment, see #2013) because Gson still targets Java 7 and just includes module-info.class for convenience for Java 9 or newer users.

Though Require-Capability seems to be auto-generated (when omitted from bnd.bnd), but maybe it does not hurt to specify it explicitly anyway.

Do you want to update your PR nonetheless in case you think there are still changes needed for Gson?

@mbooth101
Copy link
Author

Do you want to update your PR .....?

Not really, looks like this PR was ignored (and I totally forgot about it tbh) and someone ended up duplicating the work in another PR.... Feel free to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants