Fixing issue #1592 #1623
Merged
Fixing issue #1592 #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding null parameter check to name(), fixing the issue and being consistent with superclass behavior
fmmmlee
changed the title
Closed
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Oct 20, 2021
adding null parameter check to name(), fixing the issue and being consistent with superclass behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Condensed #1620.
As cqjason describes in issue #1592, the behavior of
JsonTreeWriter.name()is inconsistent with the method it overrides in its parent JsonWriter. When callingJsonWriter.name(null), a NullPointerException is thrown, while callingJsonTreeWriter.name(null)does not throw an exception, leading to a potentially misleading IllegalStateException when callingJsonTreeWriter.value()later in execution.To resolve this, I just copied the null check from lines 385-387 of JsonWriter.