Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary Number implementation for Object and Number deserialization #1290

Merged
merged 6 commits into from Oct 9, 2021
Merged

Support arbitrary Number implementation for Object and Number deserialization #1290

merged 6 commits into from Oct 9, 2021

Commits on Oct 8, 2021

  1. Object and Number type adapters number deserialization can be configured

    @lyubomyr-shaydariv
    lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    6db535b View commit details
    Browse the repository at this point in the history

  2. Change wording of ToNumberStrategy documentation

    @Marcono1234 @lyubomyr-shaydariv
    Marcono1234 authored and lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    f485c51 View commit details
    Browse the repository at this point in the history

  3. Use inline links in doc sparingly 

    If the element has already been linked before, don't create a link for
every subsequent occurrence.

See also (slightly dated)
https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#inlinelinks
    @Marcono1234 @lyubomyr-shaydariv
    Marcono1234 authored and lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    5644fc7 View commit details
    Browse the repository at this point in the history

  4. Link to default to-number policies in ToNumberStrategy doc

    @Marcono1234 @lyubomyr-shaydariv
    Marcono1234 authored and lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    91de9d8 View commit details
    Browse the repository at this point in the history

  5. Reduce code duplication for deserializing Number

    @Marcono1234 @lyubomyr-shaydariv
    Marcono1234 authored and lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    c27dbd3 View commit details
    Browse the repository at this point in the history

  6. Hide default factory constants of NumberTypeAdapter and ObjectTypeAda… 

    …pter

This encapsulates the logic a little bit better.
Additionally refactored factory created by NumberTypeAdapter to only create
TypeAdapter once and then have factory reuse that adapter for better
performance.
    @Marcono1234 @lyubomyr-shaydariv
    Marcono1234 authored and lyubomyr-shaydariv committed Oct 8, 2021
    Copy the full SHA
    078ef00 View commit details
    Browse the repository at this point in the history