Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for use of type variable to TypeToken constructor. #1222

Closed
wants to merge 5 commits into from

Conversation

JornVernee
Copy link

A pull request that addresses my earlier issue #1219.

This adds a check to the protected TypeToken constructor that will now throw a runtime exception if the TypeToken uses a type variable. So that this design time error produces a more clear error earlier during execution.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

 into reject_typevariable

# Conflicts:
#	gson/src/test/java/com/google/gson/reflect/TypeTokenTest.java
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Jan 6, 2018
@JornVernee
Copy link
Author

JornVernee commented Jan 6, 2018

I've used a RuntimeException because getSuperclassTypeParameter does the same for missing type parameters. So I think that issue can be ignored?

I've also made the accessibility of the usesTypeVariable method the same as getSuperclassTypeParameter. That could also be made private not sure what to do there.

I also haven't added any javadoc yet. I see you are not using javadoc annotations, so I'm not entirely sure what to do there either. I also haven't added myself as an author in the javadoc yet, not sure if that's ok? Or if it starts at a certain level of contribution.

@JornVernee
Copy link
Author

Closing old PR

@JornVernee JornVernee closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants