Code cleanup #2282
Code cleanup #2282
Conversation
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
metrics/src/main/java/com/google/gson/metrics/BagOfPrimitives.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks, some of these changes are clear improvements! I agree with @Marcono1234 about the formatting concerns, though, so can you fix those?
metrics/src/main/java/com/google/gson/metrics/BagOfPrimitives.java
Outdated
Show resolved
Hide resolved
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
|
Yes, i read your suggestions and I agree. In the next days, when I have more free time, I will fix everything EDIT: Well, I found the time today 😆 |
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
metrics/src/main/java/com/google/gson/metrics/BagOfPrimitives.java
Outdated
Show resolved
Hide resolved
|
If you want I can run in the google-java-format in the project so everything could be formatted. Let me know @eamonnmcmanus |
No, please don't do that. We should probably do it at some point, in a PR with no other changes, but we've hesitated to because it would mean any outstanding PRs would probably get a bunch of annoying merge work to do. |
extras/src/main/java/com/google/gson/typeadapters/UtcDateTypeAdapter.java
Outdated
Show resolved
Hide resolved
Ohh yes, make sense. Thank you for explaining 😄
I don't know why Github don't show the indentation changes. If you look at this commit, for me it's fine |
|
The indentation problem is still there, including in the commit you referenced. It should look like this: ..public Date read(JsonReader in) throws IOException {
....try {
......switch (in.peek()) {
........case NULL:
..........in.nextNull();but obviously with spaces instead of dots. It doesn't look as if there are any real changes to that file anyway, so maybe just restore it to what it was? (Also make sure that you don't have whitespace changes hidden: Files changed > ⚙️ > Hide whitespace.) |
|
Most welcome! i'm happy to help 😃 |
* Simplify `if` condition in JsonReader.peekNumber() * Remove `if` to simplify a `return` in Excluder.excludeClassChecks() * Remove redundant variable in Gson.fromJson() * equal condition replace by `Objects.equals()` in $Gson$Types.equal() * equal condition replace by `Objects.equals()` in LinkedTreeMap.equal() * Replace `switch` with `if` in UtcDateTypeAdapter.read() * Remove redundant `throws` clause in GraphAdapterBuilder.read() * Remove redundant `throws` clause in JsonTreeReader.UNREADABLE_READER * Remove redundant `throws` clause in JsonTreeWriter.UNREADABLE_READER * Remove unnecessary `.initCause()` call * Remove redundant cast in TreeTypeAdapter.GsonContextImpl.deserialize * Replace `StringBuilder` with `String` * Fix the import and restore the `switch` * Fix the import * Add the `util.Objects` import * Fix indentation * Add a comment to clarify the condition * Fix indentation * Fix imports * Fix indentation * Fix indentation * Fix indentation (cherry picked from commit 0a42c31)
I have cleanup the codebase