Remove Maven toolchain requirement

google · Jun 4, 2021 · 6819419 · 6819419
1 parent 3acc2e4
commit 6819419
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/gson/pom.xml b/gson/pom.xml
@@ -25,11 +25,13 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <version>3.0.0-M5</version>
         <configuration>
-          <jdkToolchain>
-            <!-- Use Java 11 for tests -->
-            <version>11</version>
-          </jdkToolchain>
           <!-- Deny illegal access, this is required for ReflectionAccessTest -->
+          <!-- Requires Java >= 9; Important: In case future Java versions 
+            don't support this flag anymore, don't remove it unless CI also runs with 
+            that Java version. Ideally would use toolchain to specify that this should 
+            run with e.g. Java 11, but Maven toolchain requirements (unlike Gradle ones) 
+            don't seem to be portable (every developer would have to set up toolchain 
+            configuration locally). -->
           <argLine>--illegal-access=deny</argLine>
         </configuration>
       </plugin>