Another take on HTTP mode #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
force-pushed
the
master
branch
2 times, most recently
from
f4fa19b
to
8d0aff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds communication over HTTP, so it would be possible to use existing server to serve gops traffic. All previous modes are preserved as-is; so both local and rawsocket-remote modes are still there.
I've refactored client code a bit so that both socket and HTTP modes would be possible to use; now there's a
Clientiface implemented byClientTCPandClientHTTPthat is passed to every gops command's function instead of rawTCPAddr.To use it run gops like this:
gops pprof-cpu http://localhost:port/handler