add stack-legacy command to dump call traces in legacy format #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately legacy format is more helpful in debug as it dumps goroutine labels. 'gops stack' doesn't dump them. Golang issue: golang/go#63712
tklauser
reviewed
Oct 25, 2023
Comment on lines
+211
to
+212
| case signal.StackTraceLegacy: | ||
| return pprof.Lookup("goroutine").WriteTo(conn, 1) |
There was a problem hiding this comment.
Instead of adding a new command, would there be a way to pass the debug argument to the agent as part of the existing signal.StackTrace command? If this is not possible in a backwards-compatible way, I'd suggest instead to add a new more generic command which allows to pass the debug value as part of the command invocation, so users could e.g. use debug=0 to write in compressed format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately legacy format is more helpful in debug as it dumps goroutine labels. 'gops stack' doesn't dump them.
Golang issue: golang/go#63712