Remove some named returns #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch. Looks like the build failure is related though: https://github.com/google/gops/actions/runs/6421052805/job/17434527909?pr=228#step:5:13 |
Oops, let me fix it. I did |
glibsm
force-pushed
the
pr/glibsm/remove-named-returns
branch
2 times, most recently
from
044d212
to
4950b45
Compare
tklauser
reviewed
Oct 5, 2023
Named returns should only be used with naked returns, or a deferred function. And in general are better avoided
glibsm
force-pushed
the
pr/glibsm/remove-named-returns
branch
from
4950b45
to
b30bf6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Named returns should only be used with naked returns, or a deferred function. And in general are better avoided