don't fail if can't save config due to EROFS or EPERM #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
tklauser
approved these changes
Oct 5, 2023
and gracefulShutdown() should be called on success only. Signed-off-by: Alex Lyashko <alex.lyashko@gmail.com>
Signed-off-by: Alex Lyashko <alex.lyashko@gmail.com>
agent still works in remote mode and executable environment may not allow to save any data at all (e.g. in k8s container), so be robust. Signed-off-by: Alex Lyashko <alex.lyashko@gmail.com>
tklauser
added a commit
that referenced
this pull request
Oct 5, 2023
After #213 the portfile might no longer be written, thus check the listener to determine whether the agent is already listening.
tklauser
added a commit
that referenced
this pull request
Oct 5, 2023
After #213 the portfile might no longer be written, thus check the listener to determine whether the agent is already listening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In k8s environments one can have read-only file system or no home directory at all (distroless env),
so don't fail start as we have remote listener anyway.