Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error out when the given duration is negative #155

Merged
merged 2 commits into from Nov 10, 2021
Merged

Error out when the given duration is negative #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9cfde3
Validate processInfo period & log a fatal error in the case of negati…
el10savio Nov 10, 2021
cec8c29
Update main.go
el10savio Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions main.go
View file
Open in desktop
Expand Up @@ -136,6 +136,9 @@ func processes() {
}

func processInfo(pid int, period time.Duration) {
if period < 0 {
log.Fatalf("Cannot determine CPU usage for negative duration %v", period)
}
p, err := process.NewProcess(int32(pid))
if err != nil {
log.Fatalf("Cannot read process info: %v", err)
Expand All @@ -152,10 +155,8 @@ func processInfo(pid int, period time.Duration) {
if v, err := p.CPUPercent(); err == nil {
fmt.Printf("cpu usage:\t%.3f%%\n", v)
}
if period > 0 {
if v, err := cpuPercentWithinTime(p, period); err == nil {
fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)
}
if v, err := cpuPercentWithinTime(p, period); err == nil {
fmt.Printf("cpu usage (%v):\t%.3f%%\n", period, v)
}
if v, err := p.Username(); err == nil {
fmt.Printf("username:\t%v\n", v)
Expand Down