Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add added_by and last_used fields to keys #2718

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

chapurlatn
Copy link
Contributor

Fixes #2717 by adding fields and accessors

@google-cla
Copy link

google-cla bot commented Mar 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chapurlatn chapurlatn changed the title Add added_by and last_used fields on keys Add fields added_by and last_used fields on keys Mar 27, 2023
@gmlewis gmlewis changed the title Add fields added_by and last_used fields on keys Add added_by and last_used fields to keys Mar 27, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

According to: https://www.githubstatus.com/incidents/52z0j6phhnjs
there was a GitHub Actions outage that prevented tests from being run on this PR.
Manually restarting them now.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

Unable to manually restart the jobs. Hoping GitHub tech support will unblock the pending GitHub Actions that currently appear to be zombies.

@chapurlatn chapurlatn changed the title Add added_by and last_used fields to keys Add fields added_by and last_used fields to keys Mar 27, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

Closing and reopening... hoping to re-trigger the stuck GitHub Actions...

@gmlewis gmlewis closed this Mar 27, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

Reopening...

stuck-github-actions-2023-03-27_13-54-01

@gmlewis gmlewis reopened this Mar 27, 2023
@gmlewis
Copy link
Collaborator

gmlewis commented Mar 27, 2023

Bravo - tests are now running.

@gmlewis gmlewis changed the title Add fields added_by and last_used fields to keys Add added_by and last_used fields to keys Mar 27, 2023
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @chapurlatn !
LGTM.
Merging.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #2718 (804f078) into master (3135011) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2718   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files         131      131           
  Lines       11459    11459           
=======================================
  Hits        11236    11236           
  Misses        152      152           
  Partials       71       71           
Impacted Files Coverage Δ
github/users_keys.go 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gmlewis gmlewis merged commit 795005a into google:master Mar 27, 2023
@chapurlatn chapurlatn deleted the patch-1 branch March 29, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key model is missing expected added_by and last_used.
2 participants