Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go generate mention to CONTRIBUTING.md #2587

Merged
merged 12 commits into from
Feb 13, 2023
Merged

Add go generate mention to CONTRIBUTING.md #2587

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e1f29fe
add go generate mention to CONTRIBUTING.md
XaurDesu Nov 30, 2022
b0f971d
Merge branch 'google:master' into #2579
XaurDesu Jan 31, 2023
920f08e
add command descriptions + Go documentation link to CONTRIBUTING.MD
XaurDesu Feb 3, 2023
c8a4e9b
Merge branch 'master' into #2579
XaurDesu Feb 3, 2023
9fbf983
Update CONTRIBUTING.md with suggestion
XaurDesu Feb 3, 2023
ed25857
Update CONTRIBUTING.md with suggestion
XaurDesu Feb 3, 2023
74dcf5a
revert numbering changes
XaurDesu Feb 3, 2023
a006a42
format line length
XaurDesu Feb 3, 2023
f0028b6
Update CONTRIBUTING.md
XaurDesu Feb 4, 2023
a69ca5b
Update CONTRIBUTING.md
XaurDesu Feb 4, 2023
68995d1
Update CONTRIBUTING.md
XaurDesu Feb 6, 2023
f47debd
Merge branch 'master' into #2579
XaurDesu Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ are more sensitive, emailed to <opensource@google.com>.
messages are able to be formatted properly by various git tools.

1. Finally, push the commits to your fork and submit a [pull request][].
Before pushing commits, it is highly advised to check for generated files
that were either created or modified for the sake of your commit. Running
`go generate -x ./...` should return a log of modified generated files that should
be included alongside the manually written code in the commit.
**NOTE:** Please do not use force-push on PRs in this repo, as it makes
it more difficult for reviewers to see what has changed since the last
code review.
Expand Down