Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to dependency on golang.org/x/tools to v0.1.12. #327

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

timothy-king
Copy link
Member

This prevents crashes on Go code containing generics. The standard library now contains generics at head and levee crashes for folks using newer toolchains.

See kubernetes/kubernetes#111452.

Reflects running:

go get golang.org/x/tools@v0.1.12
go mod tidy

Fixes #326

This prevents crashes on Go code containing generics. The standard library now contains generics at head and levee crashes for folks using newer toolchains.

See kubernetes/kubernetes#111452.
@PurelyApplied PurelyApplied self-requested a review August 8, 2022 22:16
Copy link
Collaborator

@PurelyApplied PurelyApplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also overlapping with #325, but a test that uses generics would be a good thing to include.

I kind of feel like this should be folded into #325, so that PR doesn't need all the interface{} to any edits but could keep everything else (with or without the base 1.18 requirement).

@timothy-king
Copy link
Member Author

I kind of feel like this should be folded into #325, so that PR doesn't need all the interface{} to any edits but could keep everything else (with or without the base 1.18 requirement).

I am not sure which order you are suggesting. This then #325. Or #325 then this?

Copy link
Collaborator

@PurelyApplied PurelyApplied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your other comment provided some clarity I was missing. We can figure out how to pick up the desired bits of #325 after this.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes when analyzing Go 1.19 standard libraries
2 participants