Skip to content

Commit

Permalink
Treat RestartRequest arguments identical to Launch/Attach arguments (#89
Browse files Browse the repository at this point in the history
)

The restart request contains the last launch or attach arguments and
should also be treated as an opaque embedded JSON message.

Signed-off-by: Cornelius Weig <22861411+corneliusweig@users.noreply.github.com>
  • Loading branch information
corneliusweig committed Feb 12, 2024
1 parent 021ca71 commit f1fa77f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
3 changes: 2 additions & 1 deletion cmd/gentypes/gentypes.go
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ func emitToplevelType(typeName string, descJson json.RawMessage, goTypeIsStruct
} else {
fmt.Fprintf(&b, "\t%s %s `json:\"body,omitempty\"`\n", "Body", bodyTypeName)
}
} else if propName == "arguments" && (typeName == "LaunchRequest" || typeName == "AttachRequest") {
} else if propName == "arguments" && (typeName == "LaunchRequest" || typeName == "AttachRequest" || typeName == "RestartRequest") {
// Special case for LaunchRequest or AttachRequest arguments, which are implementation
// defined and don't have pre-set field names in the specification.
fmt.Fprintln(&b, "\tArguments json.RawMessage `json:\"arguments\"`")
Expand Down Expand Up @@ -563,6 +563,7 @@ var typesExcludeList = map[string]bool{
// Therefore, this type is not used anywhere.
"LaunchRequestArguments": true,
"AttachRequestArguments": true,
"RestartArguments": true,
}

func main() {
Expand Down
7 changes: 1 addition & 6 deletions schematypes.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit f1fa77f

Please sign in to comment.