Inline dependency on (Apache licensed) auth challenge #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
+ Coverage 71.67% 71.87% +0.20%
==========================================
Files 123 124 +1
Lines 9935 10046 +111
==========================================
+ Hits 7121 7221 +100
- Misses 2115 2123 +8
- Partials 699 702 +3 ☔ View full report in Codecov by Sentry. |
This code was made internal in distribution/distribution#4126, because it was not intended to be consumed externally. As it is Apache-licensed, start by inlining the dependency; we can then enhance test coverage and address any shortcomings.
justinsb
force-pushed
the
inline_docker_distribution_dependency
branch
from
bd30472
to
5445c5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was made internal in distribution/distribution#4126,
because it was not intended to be consumed externally.
As it is Apache-licensed, start by inlining the dependency; we can
then enhance test coverage and address any shortcomings.