Ensure we can access layer by diffID on a mutated image #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, calling LayerByDiffID() immediately after adding a layer would error with the layer not found. By ensuring that we call "compute" on the image before trying to access the diffID map, we ensure that the layer is found. Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
This Pull Request is stale because it has been open for 90 days with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 71.67% 71.65% -0.03%
==========================================
Files 123 123
Lines 9935 9938 +3
==========================================
Hits 7121 7121
- Misses 2115 2117 +2
- Partials 699 700 +1 ☔ View full report in Codecov by Sentry. |
|
@codecov-commenter I disagree! Maintainers, any opposition to merging this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
calling LayerByDiffID()immediately after adding a layer would error with the layer not found.By ensuring that we call "compute" on the image before trying to access the diffID map, we ensure that the layer is found.