Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not inhibit the dead code elimination. #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not inhibit the dead code elimination. #341

wants to merge 1 commit into from

Commits on Sep 17, 2023

  1. Do not inhibit the dead code elimination. 

    Avoid calls to value.TypeString() that do not request fully qualified
type names. The implementation of TypeString() depends on getting
methods by index which disables the DCE in the compiler.

k8s.io/kube-openapi and k8s.io/apiserver happen to depend on go-cmp
outside tests so it is important that go-cmp does not inhibit the DCE
inadvertently.
    @dominiquelefevre
    dominiquelefevre committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    bc3dc02 View commit details
    Browse the repository at this point in the history