Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub/kafkapubsub: Configuring key_name when OpenTopicURL #3404

Merged
merged 1 commit into from Mar 18, 2024

Conversation

ssetin
Copy link
Contributor

@ssetin ssetin commented Mar 18, 2024

This PR introduce possibility to configure message key option when opening topic by url.

Related issue in krakend-pubsub

@ssetin ssetin marked this pull request as ready for review March 18, 2024 08:27
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.13%. Comparing base (9f34166) to head (7c3130d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3404      +/-   ##
==========================================
+ Coverage   73.12%   73.13%   +0.01%     
==========================================
  Files         113      113              
  Lines       14856    14862       +6     
==========================================
+ Hits        10864    10870       +6     
  Misses       3218     3218              
  Partials      774      774              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vangent vangent merged commit 1f3e996 into google:master Mar 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants