Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pubsub: add batch timeouts #3383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Feb 27, 2024

  1. pubsub: Ensure batcher flushes on shutdown, even if min batch size is…

    …n't met
    
    This PR ensures that the batcher flushes on shutdown, even if the
    pending length is less than the min batch size specified.  Sending
    events is preferred to dropping, even if limits are not obeyed.
    tonyhb committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7672fca View commit details
    Browse the repository at this point in the history
  2. pubsub: add batch timeouts

    This PR adds a timeout option to batcher.  The timeout specifies how
    long the batcher waits before sending batched messages, even if the
    message length is under MinBatchSize.
    
    This ensures delivery guarantees within a given time period if there
    are low-throughput messages with a higher min batch size.
    
    To do:
    
    - [x] Implement batch timeouts in options
    - [x] Only allow one concurrent request to check for timeouts
    - [x] Handle timeouts when grabbing next batch
    - [ ] Tests
    tonyhb committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7a77e0b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6a3015 View commit details
    Browse the repository at this point in the history
  4. Add tests for batch timeouts

    tonyhb committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    bbe768a View commit details
    Browse the repository at this point in the history