Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob/s3blob: Stop escaping second / in //; it's no longer necessary #3251

Merged
merged 1 commit into from May 12, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented May 12, 2023

Fixes #3246.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #3251 (65e9599) into master (aeb26ed) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 65e9599 differs from pull request most recent head f4a2dda. Consider uploading reports for the commit f4a2dda to get more accurate results

@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   77.36%   77.35%   -0.01%     
==========================================
  Files         103      103              
  Lines       13548    13550       +2     
==========================================
+ Hits        10481    10482       +1     
  Misses       2339     2339              
- Partials      728      729       +1     
Impacted Files Coverage Δ
blob/s3blob/s3blob.go 89.74% <ø> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

@vangent vangent merged commit d11bbf6 into google:master May 12, 2023
4 checks passed
@vangent vangent deleted the s3slash branch May 12, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

blob/s3blob: escapeKey converts "//" incorrectly
1 participant