Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blob: Add Upload and Download methods that may be more efficient for some drivers #3248

Merged
merged 1 commit into from Jun 13, 2023

Conversation

vangent
Copy link
Contributor

@vangent vangent commented May 9, 2023

Fixes #3245
Fixes #2807

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3248 (7234410) into master (0cc16c8) will decrease coverage by 0.03%.
The diff coverage is 72.30%.

@@            Coverage Diff             @@
##           master    #3248      +/-   ##
==========================================
- Coverage   77.37%   77.34%   -0.03%     
==========================================
  Files         103      103              
  Lines       13550    13599      +49     
==========================================
+ Hits        10484    10518      +34     
- Misses       2337     2346       +9     
- Partials      729      735       +6     
Impacted Files Coverage Δ
blob/driver/driver.go 66.66% <ø> (ø)
blob/memblob/memblob.go 93.29% <ø> (+0.23%) ⬆️
blob/s3blob/s3blob.go 90.00% <ø> (+0.25%) ⬆️
blob/blob.go 87.10% <60.00%> (-2.04%) ⬇️
blob/azureblob/azureblob.go 87.28% <90.90%> (+0.45%) ⬆️
blob/fileblob/fileblob.go 82.09% <100.00%> (+0.11%) ⬆️

... and 2 files with indirect coverage changes

@vangent vangent merged commit 0c8428b into google:master Jun 13, 2023
6 checks passed
@vangent vangent deleted the upload branch June 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant