blob/s3blob: adds support for per-request s3v2 Options, implementing #3214 #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vangent
requested changes
Mar 23, 2023
This commit addresses PR feedback by fixing the original incorrect reference to GCS (instead of AWS), and also the two new mentions introduced in the prior commit. Also addresses the code style for the new As test cases to be more consistent with some of the other cases.
|
I believe I have addressed the feedback, thanks 👍 |
Codecov Report
@@ Coverage Diff @@
## master #3238 +/- ##
==========================================
+ Coverage 77.34% 77.42% +0.07%
==========================================
Files 103 103
Lines 13548 13552 +4
==========================================
+ Hits 10479 10492 +13
+ Misses 2340 2334 -6
+ Partials 729 726 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vangent
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support in the blob/s3blob driver for per-request s3 options when using the underlying v2 AWS SDK.
Specifically, adds As support for:
ListOptions.BeforeList(V2) for the type*[]func(*s3v2.Options)ReaderOptions.BeforeRead(V2) for the type*[]func(*s3v2.Options)which gives the application the ability to supply per-request options when using the V2 SDK.
There does not appear to be any utility in doing the same for
BeforeWritebecause we already expose access to thes3v2manager.Uploaderwhich includes theClientOptionslist.