Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub/kafkapub: fix nil pointer dereference #3211

Merged
merged 1 commit into from Jan 15, 2023
Merged

pubsub/kafkapub: fix nil pointer dereference #3211

merged 1 commit into from Jan 15, 2023

Commits on Jan 15, 2023

  1. pubsub/kafkapub: nil pointer dereference 

    `ExampleOpenTopic` (pubsub/kafkapubsub/example_test.go) show a
simple call to `OpenTopic` without `kafkapubsub.TopicOptions` as
passing a `nil` argument.
This is done by replacing a `nil` pointer with the appropriate
zero-value.  This behaviour exists in `OpenSubscription` too.
However, PR google#3163 introduced overriding batching options which
inadvertently accesses a field of a nil pointer.
    @danielorbach
    danielorbach committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    a5b7e6c View commit details
    Browse the repository at this point in the history