-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify CJK subset definitions on Cactus, Chocolate, and LXGW Wenkai projects #7746
Conversation
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] CactusClassicalSerif-Regular.ttfAll other checks[25] CactusClassicalSerif-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif', OFL text has 'https://github.com/MoonlitOwen/CactusSerif' and HTML description has 'github.com/MoonlitOwen/CactusSerif' [code: mismatch]🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 2 | 16 | 69 | 10 | 154 | 0 |
0% | 0% | 1% | 6% | 27% | 4% | 61% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ChocolateClassicalSans-Regular.ttfAll other checks[30] ChocolateClassicalSans-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans', OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' and HTML description has 'github.com/MoonlitOwen/ChocolateSans' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 20 | 63 | 10 | 155 | 0 |
0% | 0% | 1% | 8% | 25% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
The CI fail is due to extremely long text in the fontbakery report that prevents us from being able to push the report to the PR thread on GitHub. Nothing changed in the font binaries here. This is a simple metadata file change. Will merge. cc @m4rc1e |
This reduces the CJK subsetter definitions to a single TC subset at Rod's request