Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify CJK subset definitions on Cactus, Chocolate, and LXGW Wenkai projects #7746

Merged
merged 1 commit into from
May 17, 2024

Conversation

chrissimpkins
Copy link
Collaborator

This reduces the CJK subsetter definitions to a single TC subset at Rod's request

Copy link

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] CactusClassicalSerif-Regular.ttf
⚠️ WARN Validate location, size and resolution of article images.
  • ⚠️ WARN

    Family metadata at ofl/cactusclassicalserif does not have an article.


    [code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[25] CactusClassicalSerif-Regular.ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/MoonlitOwen/CactusSerif', OFL text has 'https://github.com/MoonlitOwen/CactusSerif' and HTML description has 'github.com/MoonlitOwen/CactusSerif'

[code: mismatch]
🔥 FAIL Ensure files are not too large.
  • 🔥 FAIL

    Font file is 26.8Mb, larger than limit 9.0Mb


    [code: massive-font]
⚠️ WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value
  • ⚠️ WARN

    GPOS table lacks kerning information.


    [code: lacks-kern-info]
⚠️ WARN Does the font contain chws and vchw features?
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2
  • Glyph name: uni21B9 Contours detected: 2 Expected: 4

  • Glyph name: uni2552 Contours detected: 1 Expected: 2

  • Glyph name: uni2553 Contours detected: 1 Expected: 2

  • Glyph name: uni2555 Contours detected: 1 Expected: 2

  • Glyph name: uni2556 Contours detected: 1 Expected: 2

  • Glyph name: uni2558 Contours detected: 1 Expected: 2

  • Glyph name: uni2559 Contours detected: 1 Expected: 2

  • Glyph name: uni255B Contours detected: 1 Expected: 2

  • Glyph name: uni255C Contours detected: 1 Expected: 2

  • 14 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 576: greater, equal, minus, logicalnot, plus, less

Width = 840: uni3012

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- cjkradicalspiritonehani

- cjkradicalspirittwohani

- glyph56811

- glyph56899

- glyph57184

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    cjkcompatibilityideograph2f804hani, cjkcompatibilityideograph2f80fhani, cjkcompatibilityideograph2f815hani, cjkcompatibilityideograph2f81ahani, cjkcompatibilityideograph2f822hani, cjkcompatibilityideograph2f828hani, cjkcompatibilityideograph2f833hani, cjkcompatibilityideograph2f83fhani, cjkcompatibilityideograph2f846hani, cjkcompatibilityideograph2f852hani and 384 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]
⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* cjkcompatibilityideograph2f86dhani (U+2F86D): B<<635.0,456.0>-<615.0,443.0>-<577.0,438.0>>/L<<577.0,438.0>--<745.0,438.0>> = 7.495857639729836

* cjkcompatibilityideograph2f8d3hani (U+2F8D3): L<<766.0,555.0>--<386.0,555.0>>/L<<386.0,555.0>--<441.0,543.0>> = 12.308015817427924

* cjkcompatibilityideograph2f921hani (U+2F921): B<<332.0,634.0>-<328.0,610.0>-<307.0,607.0>>/L<<307.0,607.0>--<612.0,607.0>> = 8.13010235415596

* cjkcompatibilityideograph2f921hani (U+2F921): L<<200.0,607.0>--<299.0,607.0>>/B<<299.0,607.0>-<288.0,609.0>-<278.0,617.0>> = 10.304846468766044

* cjkcompatibilityideographf910hani (U+F910): L<<422.0,224.0>--<412.0,232.0>>/B<<412.0,232.0>-<435.0,204.0>-<434.0,176.0>> = 11.939531082430465

* cjkcompatibilityideographf91dhani (U+F91D): B<<232.0,461.0>-<333.0,410.0>-<349.0,344.0>>/L<<349.0,344.0>--<349.0,575.0>> = 13.62699485989153

* cjkcompatibilityideographf939hani (U+F939): L<<760.0,380.0>--<751.0,380.0>>/B<<751.0,380.0>-<832.0,365.0>-<883.0,332.0>> = 10.491477012331599

* cjkcompatibilityideographf93bhani (U+F93B): B<<780.0,132.0>-<724.0,223.0>-<697.0,362.0>>/L<<697.0,362.0>--<697.0,18.0>> = 10.992507580267716

* cjkcompatibilityideographf93chani (U+F93C): B<<781.0,130.0>-<727.0,220.0>-<703.0,361.0>>/L<<703.0,361.0>--<703.0,18.0>> = 9.65989307844234

* cjkcompatibilityideographf93dhani (U+F93D): B<<773.0,143.0>-<713.0,245.0>-<686.0,405.0>>/L<<686.0,405.0>--<686.0,20.0>> = 9.578422919460733

* 7018 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* M (U+004D): L<<142.0,48.0>--<143.0,682.0>>

* M (U+004D): L<<738.0,334.0>--<739.0,635.0>>

* Mugrek (U+039C): L<<142.0,48.0>--<143.0,682.0>>

* Mugrek (U+039C): L<<738.0,334.0>--<739.0,635.0>>

* N (U+004E): L<<137.0,48.0>--<138.0,672.0>>

* N (U+004E): L<<183.0,609.0>--<184.0,49.0>>

* N (U+004E): L<<617.0,150.0>--<616.0,680.0>>

* N (U+004E): L<<662.0,681.0>--<661.0,-8.0>>

* Nacute (U+0143): L<<137.0,48.0>--<138.0,672.0>>

* Nacute (U+0143): L<<183.0,609.0>--<184.0,49.0>>

* 1998 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* cjkcompatibilityideographf90fhani (U+F90F) has a counter-clockwise outer contour

* cjkcompatibilityideographf922hani (U+F922) has a counter-clockwise outer contour

* cjkcompatibilityideographf923hani (U+F923) has a counter-clockwise outer contour

* cjkcompatibilityideographf94ahani (U+F94A) has a counter-clockwise outer contour

* cjkcompatibilityideographfa5chani (U+FA5C) has a counter-clockwise outer contour

* glyph10550 (U+55AB) has a counter-clockwise outer contour

* glyph10585 (U+55CE) has a counter-clockwise outer contour

* glyph10592 (U+55D5) has a counter-clockwise outer contour

* glyph10606 (U+55E3) has a counter-clockwise outer contour

* glyph10606 (U+55E3) has a counter-clockwise outer contour

* 5551 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: i̋ i̍ j̀ j́ j̃ j̄ ɨ̀ ɨ́ ɨ̂ ɨ̃ ɨ̄ ɨ̋ ɨ̌ ị̀ ị́ ị̂ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̛̋ i̛̍ i⃝̀ i⃝́ i⃝̂ i⃝̃ i⃝̄ i⃝̆ i⃝̉ i⃝̋ i⃝̌ i⃝̍ i⃞̀ i⃞́ i⃞̂ i⃞̃ i⃞̄ i⃞̆ i⃞̉ i⃞̋

Your font fully covers the following languages that require the soft-dotted feature: Ekpeye (Latn, 226,000 speakers), Ebira (Latn, 2,200,000 speakers).

Your font does not cover the following languages that require the soft-dotted feature: South Central Banda (Latn, 244,000 speakers), Dutch (Latn, 31,709,104 speakers), Bafut (Latn, 158,146 speakers), Lugbara (Latn, 2,200,000 speakers), Fur (Latn, 1,230,163 speakers), Gulay (Latn, 250,478 speakers), Kom (Latn, 360,685 speakers), Mundani (Latn, 34,000 speakers), Zapotec (Latn, 490,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Igbo (Latn, 27,823,640 speakers), Mango (Latn, 77,000 speakers), Southern Kisi (Latn, 360,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Makaa (Latn, 221,000 speakers), Ejagham (Latn, 120,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mfumte (Latn, 79,000 speakers), Avokaya (Latn, 100,000 speakers), Aghem (Latn, 38,843 speakers), Yala (Latn, 200,000 speakers), Nzakara (Latn, 50,000 speakers), Koonzime (Latn, 40,000 speakers), Vute (Latn, 21,000 speakers), Cicipu (Latn, 44,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Bete-Bendi (Latn, 100,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Dan (Latn, 1,099,244 speakers), Navajo (Latn, 166,319 speakers), Ma’di (Latn, 584,000 speakers), Sar (Latn, 500,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Basaa (Latn, 332,940 speakers), Dii (Latn, 71,000 speakers), Nateni (Latn, 100,000 speakers).

[code: soft-dotted]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
  • U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: cherokee, math, coptic, tifinagh
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage 50830 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Combined length of family and style must not exceed 32 characters.
  • ⚠️ WARN

    Name ID 6 'CactusClassicalSerif-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/cactusclassicalserif


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/cactusclassicalserif/CactusClassicalSerif-Regular.ttf
Dehinted Size 26.8Mb
Hinted Size 26.8Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.000']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 16 69 10 154 0
0% 0% 1% 6% 27% 4% 61% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Copy link

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] ChocolateClassicalSans-Regular.ttf
⚠️ WARN Validate location, size and resolution of article images.
  • ⚠️ WARN

    Family metadata at ofl/chocolateclassicalsans does not have an article.


    [code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]

All other checks

[30] ChocolateClassicalSans-Regular.ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans', OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' and HTML description has 'github.com/MoonlitOwen/ChocolateSans'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Vietnamese glyphset:

Language FAIL messages
vi_Latn (Vietnamese) Some mark glyphs were missing: ◌̂, ◌̆
[code: failed-language-shaping]
🔥 FAIL Ensure files are not too large.
  • 🔥 FAIL

    Font file is 9.5Mb, larger than limit 9.0Mb


    [code: massive-font]
⚠️ WARN Check glyphs in mark glyph class are non-spacing.
  • ⚠️ WARN

    The following spacing glyphs may be in the GDEF mark glyph class by mistake:
    uni02EA (U+02EA) and uni02EB (U+02EB)


    [code: spacing-mark-glyphs]
⚠️ WARN Check mark characters are in GDEF mark glyph class.
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    dotbelowcomb (U+0323), hookabovecomb (U+0309), horncomb (U+031B), tildecomb (U+0303), uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C) and 3 more.

Use -F or --full-lists to disable shortening of long lists.

[code: mark-chars]
⚠️ WARN Check GDEF mark glyph class doesn't have characters that are not marks.
  • ⚠️ WARN

    The following non-mark characters should not be in the GDEF mark glyph class:
    U+02EA and U+02EB


    [code: non-mark-chars]
⚠️ WARN Does the font contain chws and vchw features?
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: uni210A	Contours detected: 3	Expected: 2
  • Glyph name: uni21B9 Contours detected: 2 Expected: 4

  • Glyph name: uni2552 Contours detected: 1 Expected: 2

  • Glyph name: uni2553 Contours detected: 1 Expected: 2

  • Glyph name: uni2555 Contours detected: 1 Expected: 2

  • Glyph name: uni2556 Contours detected: 1 Expected: 2

  • Glyph name: uni2558 Contours detected: 1 Expected: 2

  • Glyph name: uni2559 Contours detected: 1 Expected: 2

  • Glyph name: uni255B Contours detected: 1 Expected: 2

  • Glyph name: uni255C Contours detected: 1 Expected: 2

  • 12 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1000 among a set of 44 math glyphs.
    The following math glyphs have a different width, though:

Width = 555: equal, plus, greater, minus, logicalnot, less

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- cid10832

- cid12623

- cid1397

- cid1398

- cid63147

- cid63150

- cid63151

[code: unreachable-glyphs]

⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    cjkcompatibilityideograph2f825hani, cjkcompatibilityideograph2f83bhani, cjkcompatibilityideograph2f840hani, cjkcompatibilityideograph2f878hani, cjkcompatibilityideograph2f894hani, cjkcompatibilityideograph2f8cdhani, cjkcompatibilityideograph2f994hani, cjkcompatibilityideograph2f9bchani, cjkcompatibilityideograph2f9d4hani, cjkcompatibilityideographf92chani and 100 more.

Use -F or --full-lists to disable shortening of long lists.

[code: legacy-long-names]
⚠️ WARN Do outlines contain any jaggy segments?
  • ⚠️ WARN

    The following glyphs have jaggy segments:

* cid12463 (U+555F): L<<181.0,-31.0>--<181.0,279.0>>/B<<181.0,279.0>-<171.0,200.0>-<148.5,121.0>> = 7.214262039206713

* cid38524 (U+8BFF): B<<394.5,99.0>-<396.0,102.0>-<398.0,104.0>>/L<<398.0,104.0>--<171.0,-54.0>> = 10.160722927637101

* cid38550 (U+8C19): L<<527.0,473.0>--<746.0,473.0>>/L<<746.0,473.0>--<716.0,479.0>> = 11.309932474020195

* cid38550 (U+8C19): L<<937.0,620.0>--<838.0,620.0>>/L<<838.0,620.0>--<855.0,617.0>> = 10.00797980144135

* cid38551 (U+8C1A): L<<940.0,675.0>--<833.0,675.0>>/L<<833.0,675.0>--<860.0,669.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<473.0,628.0>--<520.0,636.0>>/L<<520.0,636.0>--<371.0,636.0>> = 9.65989307844234

* cid38561 (U+8C24): L<<564.0,518.0>--<730.0,518.0>>/L<<730.0,518.0>--<721.0,520.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<582.0,522.0>--<564.0,518.0>>/L<<564.0,518.0>--<730.0,518.0>> = 12.528807709151522

* cid38561 (U+8C24): L<<928.0,636.0>--<836.0,636.0>>/L<<836.0,636.0>--<845.0,634.0>> = 12.528807709151522

* cid38567 (U+8C2A): L<<462.0,596.0>--<483.0,599.0>>/L<<483.0,599.0>--<353.0,599.0>> = 8.13010235415596

* 2336 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-jaggy-segments]
⚠️ WARN Do outlines contain any semi-vertical or semi-horizontal lines?
  • ⚠️ WARN

    The following glyphs have semi-vertical/semi-horizontal lines:

* cid38436 (U+8BA7): L<<203.0,58.0>--<204.0,441.0>>

* cid38436 (U+8BA7): L<<275.0,513.0>--<274.0,111.0>>

* cid38559 (U+8C22): L<<346.0,279.0>--<345.0,739.0>>

* cid38561 (U+8C24): L<<357.0,517.0>--<509.0,518.0>>

* cid38561 (U+8C24): L<<793.0,518.0>--<947.0,519.0>>

* cid59546 (U+203CB): L<<638.0,469.0>--<883.0,468.0>>

* cid59597 (U+20873): L<<693.0,611.0>--<694.0,840.0>>

* cid59641 (U+20C43): L<<729.0,305.0>--<598.0,304.0>>

* cid59851 (U+216BA): L<<564.0,632.0>--<565.0,839.0>>

* cid59893 (U+217DA): L<<868.0,634.0>--<726.0,635.0>>

* 465 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-semi-vertical]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* acutecomb (U+0301) has a counter-clockwise outer contour

* cid10339 (U+5036) has a counter-clockwise outer contour

* cid38574 (U+8C31) has a counter-clockwise outer contour

* cid59527 (U+202BF) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59539 (U+2037F) has a counter-clockwise outer contour

* cid59545 (U+203C9) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* cid59582 (U+20619) has a counter-clockwise outer contour

* 7815 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: j̀ j́ j̃ j̄ ị̀ ị́ ị̃ ị̄

The dot of soft dotted characters should disappear in other cases, for example: i̇ i̛̇ i⃝̀ i⃝́ i⃝̃ i⃝̄ i⃝̇ i⃝̉ i⃝̌ i⃞̀ i⃞́ i⃞̃ i⃞̄ i⃞̇ i⃞̉ i⃞̌ j̇ j̉ ǰ j̛̀

Your font does not cover the following languages that require the soft-dotted feature: Ejagham (Latn, 120,000 speakers), Avokaya (Latn, 100,000 speakers), Mundani (Latn, 34,000 speakers), Mango (Latn, 77,000 speakers), Cicipu (Latn, 44,000 speakers), Koonzime (Latn, 40,000 speakers), Ekpeye (Latn, 226,000 speakers), Ebira (Latn, 2,200,000 speakers), Gulay (Latn, 250,478 speakers), Zapotec (Latn, 490,000 speakers), Dii (Latn, 71,000 speakers), Fur (Latn, 1,230,163 speakers), Igbo (Latn, 27,823,640 speakers), South Central Banda (Latn, 244,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Bete-Bendi (Latn, 100,000 speakers), Kom (Latn, 360,685 speakers), Belarusian (Cyrl, 10,064,517 speakers), Sar (Latn, 500,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Nzakara (Latn, 50,000 speakers), Lugbara (Latn, 2,200,000 speakers), Lithuanian (Latn, 2,357,094 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Bafut (Latn, 158,146 speakers), Makaa (Latn, 221,000 speakers), Ma’di (Latn, 584,000 speakers), Dutch (Latn, 31,709,104 speakers), Southern Kisi (Latn, 360,000 speakers), Vute (Latn, 21,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Nateni (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Yala (Latn, 200,000 speakers), Navajo (Latn, 166,319 speakers), Mfumte (Latn, 79,000 speakers).

[code: soft-dotted]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Moonlit Owen is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
  • U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, syriac, tai-le, old-permic, coptic, math, canadian-aboriginal, malayalam
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+031B COMBINING HORN: not included in any glyphset definition 25863 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Combined length of family and style must not exceed 32 characters.
  • ⚠️ WARN

    Name ID 6 'ChocolateClassicalSans-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret position values for ligature glyphs on its GDEF table.


    [code: lacks-caret-pos]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/chocolateclassicalsans


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/chocolateclassicalsans/ChocolateClassicalSans-Regular.ttf
Dehinted Size 9.5Mb
Hinted Size 9.5Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 20 63 10 155 0
0% 0% 1% 8% 25% 4% 62% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@chrissimpkins
Copy link
Collaborator Author

The CI fail is due to extremely long text in the fontbakery report that prevents us from being able to push the report to the PR thread on GitHub. Nothing changed in the font binaries here. This is a simple metadata file change. Will merge.

cc @m4rc1e

@chrissimpkins chrissimpkins merged commit 1c34aef into main May 17, 2024
6 of 7 checks passed
@chrissimpkins chrissimpkins deleted the chrissimpkins-hk-family-metadata branch May 17, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants