Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwrite NL: Version 1.002 added #7728

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

vv-monsalve
Copy link
Collaborator

@vv-monsalve vv-monsalve commented May 16, 2024

Taken from the upstream repo https://github.com/TypeTogether/Playwrite at commit TypeTogether/Playwrite@30b5a7b.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] PlaywriteNL[wght].ttf
⚠️ WARN Validate location, size and resolution of article images.
  • ⚠️ WARN

    There are 3 image files in the article directory and they should be moved to an article/images subdirectory:

- ofl/playwritenl/article/Playwrite-Netherland-1.png

- ofl/playwritenl/article/Playwrite-Netherland-2.png

- ofl/playwritenl/article/Playwrite-Netherland-3.png

[code: misplaced-image-files]

All other checks

[13] PlaywriteNL[wght].ttf
🔥 FAIL Check font follows the Google Fonts vertical metric schema
  • 🔥 FAIL

    The sum of hhea.ascender + abs(hhea.descender) + hhea.lineGap is 2548 when it should be at most 2000


    [code: bad-hhea-range]
⚠️ WARN Check for points out of bounds.
  • ⚠️ WARN

    The following glyphs have coordinates which are out of bounds:

  • ('quotedblleft', 656, 1172)
  • ('quotedblleft', 656, 1161)
  • ('quotedblleft', 656, 1157)
  • ('Abreve', 1041, 1525)
  • ('Acaron', 1042, 1519)
  • ('Acaron', 1042, 1508)
  • ('Acaron', 1042, 1499)
  • ('Amacron', 1019, 1457)
  • ('Abreveacute', 1041, 1525)
  • ('Abrevedotbelow', 1041, 1525) and 18 more.

Use -F or --full-lists to disable shortening of long lists.

This happens a lot when points are not extremes, which is usually bad. However, fixing this alert by adding points on extremes may do more harm than good, especially with italics, calligraphic-script, handwriting, rounded and other fonts. So it is common to ignore this message.

[code: points-out-of-bounds]
⚠️ WARN Glyph names are all valid?
  • ⚠️ WARN

    The following glyph names may be too long for some legacy systems which may expect a maximum 31-characters length limit:
    circumflexcomb_hookabovecomb.case


    [code: legacy-long-names]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: not included in any glyphset definition 8 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, math, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Ensure variable fonts include an avar table.
  • ⚠️ WARN

    This variable font does not have an avar table.


    [code: missing-avar]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/playwritenl


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/playwritenl/PlaywriteNL[wght].ttf
Dehinted Size 333.4kb
Hinted Size 333.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: dlng-tag]

  • ℹ️ INFO

    Latn,af,ca,cs,cy,da,en,es,et,eu,fr,ga,hi,hr,hu,id,is,it,nl,no,pl,pt,ro,sk,sl,sv,tr,vi,wa,yo,zu


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 1 6 53 8 183 0
0% 0% 0% 2% 21% 3% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal merged commit c8e6836 into main May 31, 2024
7 checks passed
@emmamarichal emmamarichal deleted the gftools_packager_ofl_playwritenl branch May 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Dev / PR Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants