-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chocolate Classical Sans: Version 1.001 added #7664
Chocolate Classical Sans: Version 1.001 added #7664
Conversation
Taken from the upstream repo https://github.com/aaronbell/ChocolateSans at commit aaronbell/ChocolateSans@ce0c3c5.
The maintainer of the upstream repro is not responsive to my PR, so am submitting from my local repository. There are existing FAILS that have been reviewed with @chrissimpkins, but if there's any issues let's discuss! |
This comment was marked as outdated.
This comment was marked as outdated.
adding a description
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ChocolateClassicalSans-Regular.ttfAll other checks[31] ChocolateClassicalSans-Regular.ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com
[code: namecheck-service] 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans' and OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Is this a proper HTML snippet?
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
1 | 0 | 4 | 20 | 66 | 9 | 151 | 0 |
0% | 0% | 2% | 8% | 26% | 4% | 60% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Review - Part I: FontbakeryPlease note that I don't know the context and agreements with this font, so I prefer to check everything, I just need some confirmation :) 🔥 FAIL Shapes languages in all GF glyphsets. 🔥 FAIL Ensure files are not too large. 🔥 FAIL Check Google Fonts glyph coverage.
|
Done
Yup...
Confirmed. Latin Kernel is sufficient!
The only ligatures that I'm seeing in the font are Latin ones for |
This is fine. TC punctuation works differently than we expect, so the centered positionings are fine. For 20DD and 20DE, these are enclosing glyphs, meant to be positioned over the previous glyph, so I think it is OK for these to be as they are. |
Updated |
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ChocolateClassicalSans-Regular.ttfAll other checks[30] ChocolateClassicalSans-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans' and OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 4 | 20 | 63 | 9 | 155 | 0 |
0% | 0% | 2% | 8% | 25% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
Co-authored-by: Henry Chan <hfhchan@users.noreply.github.com>
@hfhchan, I commited your changes, I propose we go ahead, and we will add modifications if they are needed :) |
@hfhchan should we add Tian Haidong in the designers list for this font? (in the metadatas and specimen) |
FontBakery reportfontbakery version: 0.12.6 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ChocolateClassicalSans-Regular.ttfAll other checks[29] ChocolateClassicalSans-Regular.ttf🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/MoonlitOwen/ChocolateSans', OFL text has 'https://github.com/MoonlitOwen/ChocolateSans' and HTML description has 'github.com/MoonlitOwen/ChocolateSans' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Ensure files are not too large.
|
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 19 | 63 | 10 | 156 | 0 |
0% | 0% | 1% | 8% | 25% | 4% | 62% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@aaronbell |
I'm not sure if it makes sense to put my repro name in the copyright string when the upstream owner it MoonlitOwen, but I also think that it makes sense to preserve my repro name as the location of this particular version of the font since it is different than MoonlitOwen's. Thoughts? |
Ok, then I merge it, and I will notify my colleagues. If there are any issues with that, we will update it. |
Yes but I have yet to receive a reply from them about the preferred transliteration.
Yes, I can confirm TC punctuation is always supposed to be in the middle. |
Taken from the upstream repo https://github.com/aaronbell/ChocolateSans at commit aaronbell/ChocolateSans@ce0c3c5.