Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monda: Version 2.200 added #7549

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Monda: Version 2.200 added #7549

merged 4 commits into from
Apr 26, 2024

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Apr 12, 2024

Taken from the upstream repo https://github.com/googlefonts/mondaFont at commit googlefonts/mondaFont@13ca3d8.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal added I Font Upgrade III VF Replacement Replace an existing family of static fonts with variable fonts labels Apr 12, 2024
@emmamarichal emmamarichal linked an issue Apr 12, 2024 that may be closed by this pull request
ofl/monda/DESCRIPTION.en_us.html Outdated Show resolved Hide resolved
@vv-monsalve
Copy link
Collaborator

@emmamarichal It seems the is a conflict between the static and VF fonts. See build

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Apr 12, 2024
@emmamarichal
Copy link
Collaborator Author

@vv-monsalve I have the feeling it's a conflict with the old versions, since it's a VF replacement. Maybe it's something related to the new packager? But I see it packages the right file though.
I don't have any issues locally, here you can find the QA I exported. We can talk about this in the next pipeline meeting if Simon is here!

Monda_QA.zip

@vv-monsalve
Copy link
Collaborator

I have the feeling it's a conflict with the old versions, since it's a VF replacement. Maybe it's something related to the new packager?

From our last tool meeting I think so. Perhaps given you updated the path to the VF on the metadata file before running it (AFAIR).

But I see it packages the right file though.

I re-download the qa from the CI run and this is what happens with it
Screen Shot 2024-04-17 at 12 32 46

As discussed on the meeting today, we better wait to review the reported error from the CI build with Marc next week.

Alternatively you could try to update the PR from packager (e.g. from a release with clean new paths to fonts)

@emmamarichal
Copy link
Collaborator Author

emmamarichal commented Apr 18, 2024

Ah, I maybe have a more precise idea. This was a case a bit special, since it's a VF replacement. I edited the metadata.pb that already exists, to change the path to /variable/monda[wght] instead of /ttf/monda-regular.ttf etc.

But I forgot to change the fonts infos in metadata. There are still on bold and regular.
Even if the metadata.pb has been solve by the packager, maybe the conflict is here. I'll try to solve it today.

Screenshot 2024-04-18 at 11 05 32

@emmamarichal
Copy link
Collaborator Author

@vv-monsalve, I can't unblock the PR because of the "changes requested" :/

@vv-monsalve vv-monsalve dismissed their stale review April 24, 2024 14:38

I worked on the request and it's solved now

@m4rc1e m4rc1e force-pushed the gftools_packager_ofl_monda branch from cccd931 to a84dd49 Compare April 24, 2024 14:55
@m4rc1e m4rc1e merged commit 736b432 into main Apr 26, 2024
7 of 8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_monda branch April 26, 2024 10:26
@emmamarichal emmamarichal removed the -- Needs confirmation from upstream or onboarder label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade III VF Replacement Replace an existing family of static fonts with variable fonts
Projects
Status: In Sandbox
Development

Successfully merging this pull request may close these issues.

Update Monda [Vernon Adams]
3 participants