Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voltaire: Version 1.010; ttfautohint (v1.8.4.7-5d5b) added #7543

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Apr 11, 2024

Taken from the upstream repo https://github.com/SorkinType/Voltaire at commit SorkinType/Voltaire@552e0de.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal added III Expand glyphset more features and more language coverage II African Mostly west african non-latin and African indigenous scripts labels Apr 11, 2024
@emmamarichal emmamarichal linked an issue Apr 11, 2024 that may be closed by this pull request

This comment was marked as outdated.

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Apr 11, 2024

🔥 FAIL The following glyphs lack their case-swapping counterparts:

Some capital counterparts need to be added.

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Apr 11, 2024
@vv-monsalve
Copy link
Collaborator

@EbenSorkin, could you please confirm about the missing counterpart characters reported above?

@emmamarichal
Copy link
Collaborator Author

@vv-monsalve the work is done, he just have to merge my last PR, and then I'll update this one :)

@EbenSorkin it also concerns Calistoga and maybe Alata and Pinyon Script

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Apr 18, 2024 via email

@emmamarichal
Copy link
Collaborator Author

Updated

@emmamarichal emmamarichal removed the -- Needs confirmation from upstream or onboarder label Apr 25, 2024
Copy link

FontBakery report

fontbakery version: 0.12.3

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[3] Voltaire-Regular.ttf
⚠️ WARN Validate location, size and resolution of article images.
  • ⚠️ WARN

    Family metadata at ofl/voltaire does not have an article.


    [code: lacks-article]
ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
🔥 FAIL Check tabular widths don't have kerning.
  • 🔥 FAIL

    Kerning between zero.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between one.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between two.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between three.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between four.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between five.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between six.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between seven.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between eight.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

  • 🔥 FAIL

    Kerning between nine.tf and plusminus is -124, should be 0


    [code: has-tabular-kerning]

All other checks

[16] Voltaire-Regular.ttf
⚠️ WARN Check if each glyph has the recommended amount of contours.
  • ⚠️ WARN

    This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: Eth	Contours detected: 3	Expected: 2
  • Glyph name: dcroat Contours detected: 3 Expected: 2

  • Glyph name: hbar Contours detected: 2 Expected: 1

  • Glyph name: Lslash Contours detected: 2 Expected: 1

  • Glyph name: lslash Contours detected: 2 Expected: 1

  • Glyph name: Tbar Contours detected: 2 Expected: 1

  • Glyph name: tbar Contours detected: 2 Expected: 1

  • Glyph name: Uogonek Contours detected: 2 Expected: 1

  • Glyph name: uni0180 Contours detected: 3 Expected: 2

  • Glyph name: uni0197 Contours detected: 2 Expected: 1

  • 80 more.

Use -F or --full-lists to disable shortening of long lists.

[code: contour-count]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1061 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 875: less, greaterequal, lessequal, greater

Width = 1013: logicalnot

Width = 1239: plusminus

Width = 907: multiply

Width = 727: minus

Width = 1110: approxequal

[code: width-outliers]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- Jcaron

- uni1E2D.dotles

[code: unreachable-glyphs]

⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
  • ⚠️ WARN

    The dot of soft dotted characters used in orthographies must disappear in the following strings: į̀ į́ į̂ į̃ į̄ į̌ ɨ̀ ɨ́ ɨ̂ ɨ̃ ɨ̄ ɨ̈ ɨ̋ ɨ̌ ɨ̏ ɨ̧̀ ɨ̧́ ɨ̧̂ ɨ̧̌ ɨ̱̀ ɨ̱́ ɨ̱̈

The dot of soft dotted characters should disappear in other cases, for example: ḭ̀ ḭ́ ḭ̂ ḭ̃ ḭ̄ ḭ̆ ḭ̇ ḭ̈ ḭ̉ ḭ̊ ḭ̋ ḭ̌ ḭ̏ ḭ̑ ḭ̒ į̆ į̇ į̈ į̉ į̊

Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers), Ekpeye (Latn, 226,000 speakers), Sar (Latn, 500,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Ebira (Latn, 2,200,000 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: South Central Banda (Latn, 244,000 speakers), Southern Kisi (Latn, 360,000 speakers), Avokaya (Latn, 100,000 speakers), Zapotec (Latn, 490,000 speakers), Fur (Latn, 1,230,163 speakers), Mfumte (Latn, 79,000 speakers), Makaa (Latn, 221,000 speakers), Mango (Latn, 77,000 speakers), Koonzime (Latn, 40,000 speakers), Kom (Latn, 360,685 speakers), Nzakara (Latn, 50,000 speakers), Navajo (Latn, 166,319 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Aghem (Latn, 38,843 speakers), Yala (Latn, 200,000 speakers), Dan (Latn, 1,099,244 speakers), Gulay (Latn, 250,478 speakers), Ma’di (Latn, 584,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Igbo (Latn, 27,823,640 speakers), Dii (Latn, 71,000 speakers), Basaa (Latn, 332,940 speakers), Bafut (Latn, 158,146 speakers), Mundani (Latn, 34,000 speakers), Cicipu (Latn, 44,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Ngbaka (Latn, 1,020,000 speakers), Ejagham (Latn, 120,000 speakers), Lugbara (Latn, 2,200,000 speakers), Nateni (Latn, 100,000 speakers).

[code: soft-dotted]
⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
  • ⚠️ WARN

    It seems that Yvonne Schüttler is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.


    [code: profile-not-found]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, coptic, cherokee
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: coptic, canadian-aboriginal, old-permic, malayalam, syriac, tifinagh, math, tai-le
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee 92 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/voltaire


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- cvt 

- fpgm

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "Voltaire" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/voltaire/Voltaire-Regular.ttf
Dehinted Size 261.1kb
Hinted Size 284.7kb
Increase 23.6kb
Change 9.0 %
[code: size-impact]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
bm_Latn (Bambara) The locl feature did not affect Eng
[code: failed-language-shaping]
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
dyu_Latn (Dyula) The locl feature did not affect Eng
[code: failed-language-shaping]
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
ha_Latn (Hausa) Some base glyphs were missing: ʼ
^ Shaper produced a .notdef
[code: failed-language-shaping]
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
ig_Latn (Igbo) The locl feature did not affect Eng
[code: failed-language-shaping]
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
lg_Latn (Ganda) The locl feature did not affect Eng
[code: failed-language-shaping]
  • 🔥 FAIL

    GF_Latin_PriAfrican glyphset:

Language FAIL messages
yo_Latn (Yoruba) Shaper didn't attach gravecomb to uni025B
^ Shaper didn't attach acutecomb.case to uni0190
^ Shaper didn't attach gravecomb.case to uni0190
^ Shaper didn't attach acutecomb to uni025B
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Latin_PriAfrican glyphset:

Language WARN messages
ha_Latn (Hausa) Some auxiliary glyphs were missing: ʼ
[code: warning-language-shaping]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    All of the fonts lack a STAT table.


    [code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 9 60 9 169 0
0% 0% 1% 4% 24% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e m4rc1e merged commit 2ef7f6e into main Apr 25, 2024
8 checks passed
@m4rc1e m4rc1e deleted the gftools_packager_ofl_voltaire branch April 25, 2024 14:58
@emmamarichal emmamarichal changed the title Voltaire: Version 1.009; ttfautohint (v1.8.4.7-5d5b) added Voltaire: Version 1.009; ttfautohint (v1.8.4.7-5d5b) added May 2, 2024
@emmamarichal emmamarichal changed the title Voltaire: Version 1.009; ttfautohint (v1.8.4.7-5d5b) added Voltaire: Version 1.010; ttfautohint (v1.8.4.7-5d5b) added May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I Font Upgrade II African Mostly west african non-latin and African indigenous scripts III Expand glyphset more features and more language coverage
Projects
Status: Live
Development

Successfully merging this pull request may close these issues.

Update Voltaire
4 participants