Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Source Code Pro, version 2038 (roman), version 1.058 (italic),… #3346

Closed
wants to merge 1 commit into from

Conversation

burnsra
Copy link

@burnsra burnsra commented Apr 27, 2021

… version 1,018 (variable)

@google-cla
Copy link

google-cla bot commented Apr 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@burnsra
Copy link
Author

burnsra commented Apr 27, 2021

@googlebot I signed it!

burnsra added a commit to burnsra/homebrew-cask-fonts that referenced this pull request Apr 27, 2021
@RosaWagner RosaWagner added -- Needs manager's opinion from upper level -- Needs Upstream Resolution Upstream fix required before moving forward I Font Upgrade - Ready for Review and removed -- Needs manager's opinion from upper level -- Needs Upstream Resolution Upstream fix required before moving forward labels Apr 28, 2021
@davelab6
Copy link
Member

davelab6 commented Apr 29, 2021

@burnsra thanks for this. @m4rc1e please check these files match the Adobe originals, rename them back to what we had before, and haven't been modified, and lint them with fontbakery etc like normal :)

@brunoarueira
Copy link
Contributor

@davelab6 @burnsra Since the font needs to be updated, I'd like to propose to fix the permissions over the files, because it has an executable permission which should not be necessary!

I've already filled an issue #3342 and a pull request on #3343 to fix the wrong permission on Source Code Pro and other resources as well which I've found through the project.

@burnsra
Copy link
Author

burnsra commented Apr 29, 2021

@davelab6 / @m4rc1e Thanks for getting things moving! I had renamed the italic versions to match the names as they are in the Adobe repo currently, hoping to make any future changes from Adobe easier.

@RosaWagner
Copy link
Contributor

We just merged another version of Source Code Pro in #4010 so I close this PR. Won't be live on the API before few weeks though. Thanks for the work in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants