Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: Fix incorrect write in Float64 write method #8290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NotTsunami
Copy link

@NotTsunami NotTsunami commented Apr 23, 2024

Closes #8070, closes #6688.

Credits @Llamadmiral for pointing out the fix and @vaind for the test case.

NOTE: The currently commented out test code is still commented out as it isn't a great test case. The test will fail because no ColorT type exists (as expected). We should probably get a better test case.

// TODO currently broken because of struct builder issue, see #6688
// final monster2 = example.Monster(data); // Monster (reader)
// expect(
// // map Monster => MonsterT, Vec3 => Vec3T, ...
// monster2.toString().replaceAllMapped(
// RegExp('([a-zA-z0-9]+){'), (match) => match.group(1) + 'T{'),
// monster.toString());
//
// final monster3 = monster2.unpack(); // MonsterT
// expect(monster3.toString(), monster.toString());

Copy link

google-cla bot commented Apr 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the dart label Apr 23, 2024
@NotTsunami
Copy link
Author

Hi Llamadmiral, I attributed the commit to you because you have found the fix for it. For this to get merged with your handle in the credit, you need to sign the CLA!

@Llamadmiral
Copy link

Hello @NotTsunami,

Thanks for attributing the commit to me! I signed the CLA, and pressed rescan, I think it finished successfully.

Thanks again! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flat_buffers.dart putFloat64 is wrong [dart] Struct serialization broken
2 participants