Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++, flexbuffers] Optimizes shared key/string search implementation #8284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[C++, flexbuffers] Optimizes shared key/string search implementation #8284

wants to merge 2 commits into from

Conversation

guillaumeblanc
Copy link

Hi,

The original implementation searches twice (find + insert) in case the key/string isn't found.

Regards,
Guillaume

@guillaumeblanc
Uses std::set::insert() function return value to search only once.
9ef2399 
The original implementation searches twice (find + insert) in case the key/string isn't found.
@github-actions github-actions bot added the c++ label Apr 18, 2024
@guillaumeblanc guillaumeblanc changed the title [C++] Uses std::set::insert() function return value to search only once. [C++, flexbuffers] Uses std::set::insert() function return value to search only once. Apr 19, 2024
@guillaumeblanc guillaumeblanc changed the title [C++, flexbuffers] Uses std::set::insert() function return value to search only once. [C++, flexbuffers] Optimizes shared key/string search implementation Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@guillaumeblanc