[Python, flexbuffers] key/string sharing feature not working with Python implementation #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary search requires the pool to be sorted, which wasn't the case. Insertion now happens sorted, at the index returned by _LowerBound.
…e sorted. The new implementation prevents from duplicating a big part of the buffer ([offset:]) to just access a key or a string. The assumption is that reusing keys and strings means [offset:] can become a bigger range (offset can now be at buffer begin).
guillaumeblanc
changed the title
guillaumeblanc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Python implementation fails to share keys and stings, resulting in bigger buffers than expected.
The reason is that the Pool implementation does a binary search on an unsorted array/pool. Hence, search fails (randomly), preventing sharing.
This PR contains:
Regards,
Guillaume