lua: kKeep filenames to avoid incorrect require casing #8258
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
lua-case-sensitive-require
branch
from
ea06e3b
to
5d6b630
Compare
serprex
changed the title
Having a struct UUID, the file generated was Uuid.lua, but generated code passing UUID all uppercase to require, on case sensitive filesystems this doesn't work
serprex
force-pushed
the
lua-case-sensitive-require
branch
from
5d6b630
to
7381565
Compare
serprex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a struct UUID, the file generated was Uuid.lua,
but generated code passing UUID all uppercase to require,
on case sensitive filesystems this doesn't work
Update GenerateMethod to use namer_ Method to avoid changing
PrependInt8intoPrependint8