Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Arrays in Structs for Golang #8250

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alex1891
Copy link

@alex1891 alex1891 commented Mar 8, 2024

based on #8036 and added support for object api

This PR implements array support for golang and also supports the object api.

@github-actions github-actions bot added c++ codegen Involving generating code from schema golang labels Mar 8, 2024
@serprex
Copy link

serprex commented Mar 14, 2024

@alex1891 the last PR was closed for being stale because it didn't update tests to have arrays with go tested. Hopefully you can update this PR with a test & this can be merged

If you'd like me to take a stab at it let me know & I'll see if I can create a PR to your fork with test

@alex1891
Copy link
Author

@alex1891 the last PR was closed for being stale because it didn't update tests to have arrays with go tested. Hopefully you can update this PR with a test & this can be merged

If you'd like me to take a stab at it let me know & I'll see if I can create a PR to your fork with test

Hi Serprex,
that would be great! Because I have no idea how to provide test and it would save me a ton of tiime :)

Let me know if you need some help (e.g. example flatbuffer descriptions)

@serprex
Copy link

serprex commented Apr 28, 2024

Sorry for dropping this, I lost motivation since I'm not sure flatbuffers developers are interested in external contributions after none of my lua PRs have received any feedback. I had adjusted tests when trying to implement some arrays-in-lua support for #8254 which might show how to add tests for this PR too

Besides that, customer which had me investigating flatbuffers (& uses flatbuffers with go) has decided to go with msgpack instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants